Update ember-cli-babel to prevent errors with newer TS syntax

[rwjblue]

NOTE: Targets the 3.16 branch (as this no longer affects the current release).

@ember-data/[email protected] introduced new typescript syntax that is not guaranteed to be supported by the ember-cli-babel version that it depends on. Specifically, the version of ember-cli-babel we depend on prior to this change uses @babel/[email protected] which does not support the function foo(id: string | null) asserts id is not null {} syntax we use in fetch-manager.ts. The dependency structure looks like this (with links):

• [email protected] depends on [email protected]
• [email protected] depends on @babel/[email protected]
• @babel/[email protected] depends on @babel/[email protected]

The specific assertion syntax was not parsable until @babel/[email protected] (added by babel/babel@38a3063).

Without the changes added here, you would be able to update to [email protected] and still have an older version of @babel/parser that was incapable of parsing the syntax used by [email protected]. This would result in the following error message:

SyntaxError: app-path/-private/system/fetch-manager.ts: Unexpected token, expected "{" (506:52)

  504 | }
  505 | 
> 506 | function assertIsString(id: string | null): asserts id is string {
      |                                                     ^
  507 |   if (DEBUG) {
  508 |     if (typeof id !== 'string') {
  509 |       throw new Error(`Cannot fetch record without an id`);
    at Object.raise (app-path/node_modules/@ember-data/store/node_modules/broccoli-babel-transpiler/node_modules/@babel/parser/lib/index.js:6322:17)
    at Object.unexpected (app-path/node_modules/@ember-data/store/node_modules/broccoli-babel-transpiler/node_modules/@babel/parser/lib/index.js:7638:16)
    at Object.expect (app-path/node_modules/@ember-data/store/node_modules/broccoli-babel-transpiler/node_modules/@babel/parser/lib/index.js:7624:28)
    at Object.parseBlock (app-path/node_modules/@ember-data/store/node_modules/broccoli-babel-transpiler/node_modules/@babel/parser/lib/index.js:10305:10)
    at Object.parseFunctionBody (app-path/node_modules/@ember-data/store/node_modules/broccoli-babel-transpiler/node_modules/@babel/parser/lib/index.js:9382:24)
    at Object.parseFunctionBodyAndFinish (app-path/node_modules/@ember-data/store/node_modules/broccoli-babel-transpiler/node_modules/@babel/parser/lib/index.js:9352:10)
    at Object.parseFunctionBodyAndFinish (app-path/node_modules/@ember-data/store/node_modules/broccoli-babel-transpiler/node_modules/@babel/parser/lib/index.js:5234:11)
    at withTopicForbiddingContext (app-path/node_modules/@ember-data/store/node_modules/broccoli-babel-transpiler/node_modules/@babel/parser/lib/index.js:10474:12)
    at Object.withTopicForbiddingContext (app-path/node_modules/@ember-data/store/node_modules/broccoli-babel-transpiler/node_modules/@babel/parser/lib/index.js:9657:14)
    at Object.parseFunction (app-path/node_modules/@ember-data/store/node_modules/broccoli-babel-transpiler/node_modules/@babel/parser/lib/index.js:10473:10)

[stefanpenner]

restarting: https://travis-ci.org/github/emberjs/data/builds/696523012

[igorT]

Github actions passed, so merging. Thanks a bunch for the fix!

[stefanpenner]

@igorT / @runspired No trying to rush, just curious for planning purposes. Do we have an ETA for release?

[igorT]

This afternoon

…

On Tue, Jun 9, 2020, 13:58 Stefan Penner ***@***.***> wrote: @igorT <https://github.com/igorT> / @runspired <https://github.com/runspired> No trying to rush, just curious for planning purposes. Do we have an ETA for release? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7220 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFOTJ6O7Y44Y7I32AEZRQ3RV2O6XANCNFSM4NZRMCDA> .