Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: record.destroyRecord should also unload the record #7217

Closed

Conversation

snewcomer
Copy link
Contributor

@snewcomer snewcomer commented Jun 6, 2020

Outstanding question - is this still needed?

close #5006
close #5455

@runspired runspired changed the title Destroy record unload record.destroyRecord should also unload the record Jun 12, 2020
@runspired runspired changed the title record.destroyRecord should also unload the record feat: record.destroyRecord should also unload the record Jun 12, 2020
runspired and others added 18 commits June 15, 2020 15:55
* chore: remove instance initializer

* fix DAG
[DOC] Fix minor typo in findRecord documentation
…erjs#7247)

* [CI]: remove erroneous `name` without `run`

* add name for the job
[CI]: remove Chrome and Firefox install from Github Actions and Azure
@snewcomer snewcomer force-pushed the destroy-record-unload branch from 23720bf to 5f01bf8 Compare July 31, 2020 20:28
@snewcomer
Copy link
Contributor Author

Porting to a new PR.

@snewcomer snewcomer closed this Jul 31, 2020
@snewcomer snewcomer deleted the destroy-record-unload branch July 31, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants