[BUGFIX]: Fix errors while running yarn start #7146
Conversation
| const options = this.getEmberDataConfig(); | ||
| let compatVersion = options.compatWith; | ||
| let tree = version(compatVersion); | ||
| return this.debugTree(this._super.treeForAddon.call(this, tree), 'addon-output'); |
There was a problem hiding this comment.
So this leaks the version module into our asset-size check because we now include it in production builds from unpublished-test-infra.
I don't think it legitimately affects end consumers, but it is frustrating to have it included in the check when it should not be.
There's probably a check we could do here, but it wouldn't just be "is production" since we test production output too. Maybe we check if the command is "serve" ? @rwjblue thoughts?
There was a problem hiding this comment.
we now include it in production builds from unpublished-test-infra.
That is a great point! I assumed from the name of this package that it was not included in a published prod build; while also noticing it was a devDependency for various pkgs. Side question - is there a short explanation or module that you could point me to in order to understand why unpublished-test-infra would be included in the process of a production build?
Also, would an alternative fix involve something like process.env.EMBER_ENV?
fix Safari test issue Co-authored-by: Chris Thoburn <[email protected]>
runspired
force-pushed
the
sn/test-infra-failure
branch
from
b9ce7a0 to
1274cfc
Compare
| let compatVersion = options.compatWith; | ||
| let tree = merge([existingTree, version(compatVersion)]); | ||
|
|
||
| return this.debugTree(this._super.treeForAddonTestSupport.call(this, tree), 'addon-output'); |
There was a problem hiding this comment.
Can you change the debug tree name (this isn't the addon tree any more)?
* [BUGFIX]: Fix errors while running yarn start fix Safari test issue Co-authored-by: Chris Thoburn <[email protected]> * fix lint * Change debug name to test-support Co-authored-by: Chris Thoburn <[email protected]>
* [BUGFIX]: Fix errors while running yarn start fix Safari test issue Co-authored-by: Chris Thoburn <[email protected]> * fix lint * Change debug name to test-support Co-authored-by: Chris Thoburn <[email protected]>
* [BUGFIX]: Fix errors while running yarn start fix Safari test issue Co-authored-by: Chris Thoburn <[email protected]> * fix lint * Change debug name to test-support Co-authored-by: Chris Thoburn <[email protected]>
close #7072
This PR allows a developer to execute
yarn startand run the tests in the browser.We add the
/versionfile with some tag/sha information at build time iffEMBER_CLI_TEST_COMMANDis set by Node on the global variableprocess.envat runtime.Another option is to be more specific in the if conditional by allowing only development or test. However, if this module is excluded from production, then this may be sufficient in its current state.