Backport #7020 for LTS #7085
Merged
Backport #7020 for LTS #7085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeroicEric
commented
Mar 6, 2020
| willDestroy() { | ||
| this._super(...arguments); | ||
| this._pushedInternalModels = null; | ||
| this.recordArrayManager.destroy(); | ||
|
|
||
| this._adapterCache = null; | ||
| this._serializerCache = null; |
There was a problem hiding this comment.
@igorT these lines had already been removed by the time the original changes were made in #7020 I had to also remove them to backport this change in order for the destroy() logic above to work. I'm not totally sure what, if any, implications this might have elsewhere. I found a comment related to this https://github.com/emberjs/data/pull/6207/files#r306956786 so I was thinking you might have more context
There was a problem hiding this comment.
👍on this PR, but I will double check with @runspired and @rwjblue whether this is still correct thinking
igorT
approved these changes
Mar 6, 2020
…emberjs#7020) Prior to this change, adapters and serializers were never destroyed. Commonly (and anecdotally) this is "fine" (heck this is the first report of the issue in years!), but it is pretty common for adapters to do async of their own (e.g. tracking adapter responses, exponential backoffs, etc) and without `.destroy()` being called on them there is no way for those adapters/serializer to ensure that async is canceled appropriately.
igorT
force-pushed
the
lts-3-12-backport-7020
branch
from
d7cab00 to
d5b6ab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Ensure adapters and serializers are destroyed upon store destruction. #7020 for LTS 3.12
This required a few changes:
Adapter#destroy()was added to the baseAdapterclass rather than theMinimumAdapterInterfacebecause that interface did not yet exist