Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nightly.yml #6857

Merged
merged 7 commits into from
Dec 5, 2019
+92 −22
Merged

fix nightly.yml #6857

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3cf176b
fix nightly.yml
Gaurav0 Dec 5, 2019
5ad039e
add pull request event
Gaurav0 Dec 5, 2019
517f11a
more fixes
Gaurav0 Dec 5, 2019
decbf7d
remove pull request trigger for nightly job
Gaurav0 Dec 5, 2019
778a3fd
fix lint
Gaurav0 Dec 5, 2019
3290ad5
Revert "remove pull request trigger for nightly job"
Gaurav0 Dec 5, 2019
febab6c
Revert "Revert "remove pull request trigger for nightly job""
Gaurav0 Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,14 @@
name: 'Nightly'

on:
schedule:
- cron: '* 14 * * *' # 14:00 in UTC is 6am PST
pull_request:
branches:
- master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's bring this back, we still only want to run this on master we just also wanted to run it during PR while deving

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM:

You can schedule a workflow to run at specific UTC times using POSIX cron syntax. Scheduled workflows run on the latest commit on the default or base branch. The shortest interval you can run scheduled workflows is once every 5 minutes.

https://help.github.com/en/actions/automating-your-workflow-with-github-actions/events-that-trigger-workflows#scheduled-events-schedule

We don't need the branch specifier

schedule:
- cron: '* 14 * * *' # 14:00 in UTC is 6am PST

jobs:
test-all-deprecations:
strategy:
fail-fast: false
matrix:
scenario: [ember-beta, ember-canary]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
Expand Down
15 changes: 13 additions & 2 deletions packages/unpublished-adapter-encapsulation-test-app/testem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,20 @@
// eslint-disable-next-line node/no-unpublished-require
const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');

const TestIE = process.env.TEST_IE11;

if (TestIE) {
// eslint-disable-next-line no-console
console.log('\n\nLaunching with IE\n\n');
}

module.exports = {
test_page: 'tests/index.html?hidepassed',
disable_watching: true,
reporter: 'dot',
launch_in_ci: ['Chrome'],
reporter: customDotReporter,
launch_in_ci: TestIE ? ['IE'] : ['Chrome'],
launch_in_dev: ['Chrome'],
browser_start_timeout: 120,
browser_args: {
Chrome: {
ci: [
Expand Down
15 changes: 13 additions & 2 deletions packages/unpublished-debug-encapsulation-test-app/testem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,20 @@
// eslint-disable-next-line node/no-unpublished-require
const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');

const TestIE = process.env.TEST_IE11;

if (TestIE) {
// eslint-disable-next-line no-console
console.log('\n\nLaunching with IE\n\n');
}

module.exports = {
test_page: 'tests/index.html?hidepassed',
disable_watching: true,
reporter: 'dot',
launch_in_ci: ['Chrome'],
reporter: customDotReporter,
launch_in_ci: TestIE ? ['IE'] : ['Chrome'],
launch_in_dev: ['Chrome'],
browser_start_timeout: 120,
browser_args: {
Chrome: {
ci: [
Expand Down
14 changes: 12 additions & 2 deletions packages/unpublished-fastboot-test-app/testem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,18 @@
// eslint-disable-next-line node/no-unpublished-require
const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');

const TestIE = process.env.TEST_IE11;

if (TestIE) {
// eslint-disable-next-line no-console
console.log('\n\nLaunching with IE\n\n');
}

module.exports = {
test_page: 'tests/index.html?hidepassed',
disable_watching: true,
reporter: 'dot',
launch_in_ci: ['Chrome'],
reporter: customDotReporter,
launch_in_ci: TestIE ? ['IE'] : ['Chrome'],
launch_in_dev: ['Chrome'],
browser_start_timeout: 120,
browser_args: {
Expand Down
15 changes: 13 additions & 2 deletions packages/unpublished-model-encapsulation-test-app/testem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,20 @@
// eslint-disable-next-line node/no-unpublished-require
const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');

const TestIE = process.env.TEST_IE11;

if (TestIE) {
// eslint-disable-next-line no-console
console.log('\n\nLaunching with IE\n\n');
}

module.exports = {
test_page: 'tests/index.html?hidepassed',
disable_watching: true,
reporter: 'dot',
launch_in_ci: ['Chrome'],
reporter: customDotReporter,
launch_in_ci: TestIE ? ['IE'] : ['Chrome'],
launch_in_dev: ['Chrome'],
browser_start_timeout: 120,
browser_args: {
Chrome: {
ci: [
Expand Down
15 changes: 13 additions & 2 deletions packages/unpublished-record-data-encapsulation-test-app/testem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,20 @@
// eslint-disable-next-line node/no-unpublished-require
const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');

const TestIE = process.env.TEST_IE11;

if (TestIE) {
// eslint-disable-next-line no-console
console.log('\n\nLaunching with IE\n\n');
}

module.exports = {
test_page: 'tests/index.html?hidepassed',
disable_watching: true,
reporter: 'dot',
launch_in_ci: ['Chrome'],
reporter: customDotReporter,
launch_in_ci: TestIE ? ['IE'] : ['Chrome'],
launch_in_dev: ['Chrome'],
browser_start_timeout: 120,
browser_args: {
Chrome: {
ci: [
Expand Down
19 changes: 15 additions & 4 deletions packages/unpublished-relationship-performance-test-app/testem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,31 @@
// eslint-disable-next-line node/no-unpublished-require
const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');

const TestIE = process.env.TEST_IE11;

if (TestIE) {
// eslint-disable-next-line no-console
console.log('\n\nLaunching with IE\n\n');
}

module.exports = {
test_page: 'tests/index.html?hidepassed',
disable_watching: true,
launch_in_ci: ['Chrome'],
reporter: customDotReporter,
launch_in_ci: TestIE ? ['IE'] : ['Chrome'],
launch_in_dev: ['Chrome'],
browser_start_timeout: 120,
browser_args: {
Chrome: {
ci: [
// --no-sandbox is needed when running Chrome inside a container
process.env.CI ? '--no-sandbox' : null,
'--headless',
'--disable-dev-shm-usage',
'--disable-software-rasterizer',
'--mute-audio',
'--remote-debugging-port=0',
'--window-size=1440,900',
].filter(Boolean),
'--no-sandbox',
],
},
},
};
15 changes: 13 additions & 2 deletions packages/unpublished-serializer-encapsulation-test-app/testem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,20 @@
// eslint-disable-next-line node/no-unpublished-require
const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');

const TestIE = process.env.TEST_IE11;

if (TestIE) {
// eslint-disable-next-line no-console
console.log('\n\nLaunching with IE\n\n');
}

module.exports = {
test_page: 'tests/index.html?hidepassed',
disable_watching: true,
reporter: 'dot',
launch_in_ci: ['Chrome'],
reporter: customDotReporter,
launch_in_ci: TestIE ? ['IE'] : ['Chrome'],
launch_in_dev: ['Chrome'],
browser_start_timeout: 120,
browser_args: {
Chrome: {
ci: [
Expand Down