[BUGFIX] Octane: should not need to use get with model.id #6829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
reviewed
Dec 1, 2019
packages/-ember-data/tests/acceptance/tracking-model-id-test.js
Outdated
Show resolved
Hide resolved
Gaurav0
force-pushed
the
octane_id_bug
branch
from
7126adf to
cb5d4fa
Compare
Gaurav0
changed the title
runspired
approved these changes
Dec 2, 2019
Gaurav0
force-pushed
the
octane_id_bug
branch
from
1d2d353 to
367db13
Compare
runspired
added
🎯 beta
|
Assigned Igor for backporting. |
igorT
pushed a commit
that referenced
this pull request
Dec 14, 2019
igorT
pushed a commit
that referenced
this pull request
Dec 14, 2019
igorT
removed
🎯 release
igorT
pushed a commit
that referenced
this pull request
Dec 18, 2019
igorT
pushed a commit
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6143
Edit: Now includes a WIP bugfix, but it has TypeScript errors I don't know how to fix.