[CHORE]: eliminate initializer logic not needed after setupStore removed #6448

snewcomer · 2019-09-13T22:24:14Z

close #6357

rwjblue · 2019-09-18T14:31:56Z

Looks like we need to dig into the CI failures here.

packages/-ember-data/addon/setup-container.js

snewcomer added 2 commits September 13, 2019 15:22

[CHORE]: eliminate initializer logic not needed after setupStore removed

00a2fc1

Merge branch 'master' into sn/initializer-setup-store

6107441

snewcomer added 7 commits September 18, 2019 08:16

Merge branch 'master' into sn/initializer-setup-store

2ff6559

revert and use either method

712e8ac

naive

ca9ab13

Clean up uneeded test helpers

bfaaabe

Merge branch 'master' into sn/initializer-setup-store

afe9d2c

remove name

7ecfab6

cleanup setup-container

aed4278

runspired approved these changes Sep 18, 2019

View reviewed changes

runspired added 2 commits September 18, 2019 16:26

deprecate legacy setupContainer support

079e1e7

fix tests with ff on

b5e49b9

snewcomer commented Sep 19, 2019

View reviewed changes

packages/-ember-data/addon/setup-container.js Outdated Show resolved Hide resolved

add deprecation for registry argument to initializeStoreInjections

f141ff0

snewcomer commented Sep 19, 2019

View reviewed changes

packages/-ember-data/addon/setup-container.js Show resolved Hide resolved

runspired reviewed Sep 19, 2019

View reviewed changes

packages/-ember-data/addon/setup-container.js Outdated Show resolved Hide resolved

snewcomer added 2 commits September 18, 2019 22:45

Merge branch 'master' into sn/initializer-setup-store

315a2d5

restore deprecated code path

40fe5c4

rwjblue approved these changes Sep 19, 2019

View reviewed changes

rwjblue requested a review from runspired September 19, 2019 13:28

runspired approved these changes Sep 19, 2019

View reviewed changes

runspired merged commit 27dbe82 into emberjs:master Sep 19, 2019

snewcomer deleted the sn/initializer-setup-store branch September 19, 2019 19:01

Provide feedback