[BUGFIX RELEASE] Backport #6412 from beta #6441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some operations in Ember Data flush using `run.join`. This will flush _synchronously_ if no runloop or autorun currently exists, but will join the existing runloop otherwise, making the scheduled task effectively asynchronous. With the tracked properties feature flag enabled, the way we've scheduled autoruns has changed. A few Data tests were failing because they were expecting an operation to flush synchronously, but it flushed asynchronously due to an existing autorun. This PR adds appropriate `await settled();` statements in these cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6425