Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HTML comments in PR template. #6078

Merged
merged 1 commit into from
May 1, 2019
Merged

Use HTML comments in PR template. #6078

merged 1 commit into from
May 1, 2019

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented May 1, 2019

Using HTML comments here mean they don't need to delete anything
and simplifies the process a tad bit...

@rwjblue
Use HTML comments in PR template.
d5bec81 
Using HTML comments here mean they don't need to delete anything
and simplifies the process a tad bit...
@rwjblue rwjblue requested a review from runspired May 1, 2019 20:34
@rwjblue rwjblue merged commit 711ef31 into master May 1, 2019
@rwjblue rwjblue deleted the rwjblue/tweak-pull-request-template branch May 1, 2019 21:57
@runspired
Copy link
Contributor

@rwjblue this does not seem to have had the intended effect:

<!--

If this is your first PR to `ember-data`, you may want to read our [Contributor Guide](https://github.com/emberjs/data/blob/master/CONTRIBUTING.md).

-->

^ this is what now gets manually deleted

@runspired
Copy link
Contributor

(That or I misunderstood something about what this PR aimed to achieve)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runspired runspired runspired approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwjblue @runspired