[FEAT packages] Convert to monorepo for RFC #395 #5919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeroicEric
force-pushed
the
heroiceric/lerna-monorepo
branch
2 times, most recently
from
9c10dc6 to
c5a43d7
Compare
HeroicEric
added a commit
to HeroicEric/data
that referenced
this pull request
Mar 20, 2019
> Note: Unlike the `--global` flag in npm, `global` is a command which must > immediately follow `yarn`. Entering `yarn add global package-name` will add > the packages named `global` and `package-name` locally instead of adding > package-name globally. https://yarnpkg.com/lang/en/docs/cli/global/#toc-yarn-global --- I noticed this while working on emberjs#5919, where the following error was starting to show up in CI after converting to use yarn workspaces: ``` yarn add v1.13.0 error Running this command will add the dependency to the workspace root rather than the workspace itself, which might not be what you want - if you really meant it, make it explicit by running this command again with the -W flag (or --ignore-workspace-root-check). info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command. ```
HeroicEric
force-pushed
the
heroiceric/lerna-monorepo
branch
from
738bb97 to
92a51ad
Compare
HeroicEric
added a commit
to HeroicEric/data
that referenced
this pull request
Mar 20, 2019
This adds a script to `package.json` to run our feature linting script via `yarn lint:features` rather than using `./bin/lint-features` directly. This makes it easier to run the script from the root package after converting to a monorepo like in emberjs#5919
HeroicEric
force-pushed
the
heroiceric/lerna-monorepo
branch
from
92a51ad to
850afc9
Compare
runspired
pushed a commit
that referenced
this pull request
Mar 21, 2019
This adds a script to `package.json` to run our feature linting script via `yarn lint:features` rather than using `./bin/lint-features` directly. This makes it easier to run the script from the root package after converting to a monorepo like in #5919
runspired
pushed a commit
that referenced
this pull request
Mar 21, 2019
> Note: Unlike the `--global` flag in npm, `global` is a command which must > immediately follow `yarn`. Entering `yarn add global package-name` will add > the packages named `global` and `package-name` locally instead of adding > package-name globally. https://yarnpkg.com/lang/en/docs/cli/global/#toc-yarn-global --- I noticed this while working on #5919, where the following error was starting to show up in CI after converting to use yarn workspaces: ``` yarn add v1.13.0 error Running this command will add the dependency to the workspace root rather than the workspace itself, which might not be what you want - if you really meant it, make it explicit by running this command again with the -W flag (or --ignore-workspace-root-check). info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command. ```
HeroicEric
force-pushed
the
heroiceric/lerna-monorepo
branch
4 times, most recently
from
398a07b to
e5848bb
Compare
14 tasks
runspired
force-pushed
the
heroiceric/lerna-monorepo
branch
from
e5848bb to
0060f31
Compare
runspired
changed the title
runspired
changed the title
igorT
force-pushed
the
heroiceric/lerna-monorepo
branch
3 times, most recently
from
52bb4ad to
d5ab6ec
Compare
runspired
approved these changes
Apr 3, 2019
igorT
force-pushed
the
heroiceric/lerna-monorepo
branch
7 times, most recently
from
4072791 to
b20ae3f
Compare
|
It seems like addons which use ED work, but apps are not building/including ED properly, at least when linked locally |
|
@runspired @HeroicEric when run against Ember Observer, it seems like |
is a bit of a misleading error, but it's caused by the import from |
igorT
force-pushed
the
heroiceric/lerna-monorepo
branch
3 times, most recently
from
b775139 to
a59d3e5
Compare
Co-authored-by: Chris Thoburn <[email protected]> Co-authored-by: Igor Terzic <[email protected]>
igorT
force-pushed
the
heroiceric/lerna-monorepo
branch
from
a59d3e5 to
b876a80
Compare
|
EmberAddons still have a babel problem, so I marked them as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/emberjs/rfcs/blob/master/text/0395-ember-data-packages.md
all your disk space are belong to us