Fix missing inverse #5268
Closed
Fix missing inverse #5268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* commit 'dd3cd69462943530039428a0203f7d66beb1bfd0': Bump master version to 3.0.0-canary Update changelog for Ember Data 2.17.0 release [DOC beta] Assert that both modelName and id are passed to `peekRecord` (emberjs#4998) [doc] Update urlForFindRecord example
* commit 'ed4e45f7ca4a28a478293857442164e295eccf5b': Update ember-cli-blueprint-test-helpers fixes emberjs#5259 (emberjs#5264) Update AdapterPopulatedRecordArray to use links if available otherwise null. (emberjs#5263)
|
@stefanpenner needs some input from you. Could you comment on the direction I've taken here, storing polymorphic relationships against the base class and not the descendant class? It fixes the problem I found but breaks a couple of tests. Before I go and find out why, I wanted to check that this is the right way to go. EDIT: and about 5 seconds later I realised why they were broken... |
This was referenced Nov 30, 2017
|
Probably this has no value given #5230, but worth comparing for method |
runspired
reviewed
Feb 28, 2018
| @@ -132,9 +132,11 @@ export default class RelationshipPayloadsManager { | |||
| let modelClass = this._store._modelFor(modelName); | |||
| let relationshipsByName = get(modelClass, 'relationshipsByName'); | |||
| relationshipsByName.forEach((_, relationshipName) => { | |||
| let relationship = relationshipsByName.get(relationshipName); | |||
| let modelThatOwnsRelationship = relationship.parentType; | |||
There was a problem hiding this comment.
never trust parentType it may not have been loaded via modelFor yet and thus missing modelName
|
Closing as #5230 has landed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #5267
Initially add test to show problem