fix relationships with links #5256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when one end of a relationship is marked {inverse:null} keep the two relationships separate in the cache
minor optimisation too
Don't overwrite links in cached payload when populating the other side of a relationship
BryanCrotaz
changed the title
BryanCrotaz
changed the title
|
It's failing in the production environment as we've both added async-await. But I can't see where that's been done in master in order to avoid the clash |
|
Shame, but removing async/await fixed it |
|
Can't get clean code, so creating a new PR #5257 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #5209 and #5211
when one end of a relationship is marked
{inverse:null}keep the two relationships separate in the cache and don't create the":"cache entryminor optimisation too in
relationship-payloads.jsIn RelationshipPayloads, don't overwrite an inverse relationship if it's got links instead of data
Added ember-cli-babel polyfill to allow async/await in tests for clarity