remove needless change events when creating a recordArrays #4947
Conversation
stefanpenner
force-pushed
the
remove-change-removes
branch
from
9f43ae2 to
7ed1c8a
Compare
…ent (rather then add them after, and broadcasting change events)
stefanpenner
changed the title
| let modelsToAdd = []; | ||
| let modelsToRemove = []; | ||
|
|
||
| for (let i = 0; i < internalModels.length; i++) { |
There was a problem hiding this comment.
Does our new diffArray method work here or is the data structure different?
There was a problem hiding this comment.
Interesting. I didn't think of that, I should try
| @@ -161,6 +161,75 @@ test('recordArray.replace() throws error', function(assert) { | |||
| }, Error('The result of a server query (on person) is immutable.'), 'throws error'); | |||
| }); | |||
|
|
|||
| test('only pass record array if explicitly in arity', function(assert) { | |||
There was a problem hiding this comment.
as written, this test name is hard to understand.
maybe 'pass record array to adapter.query based on arity'
| }); | ||
| }); | ||
|
|
||
| test('only pass record array if explicitly in arity', function(assert) { |
There was a problem hiding this comment.
as written, this test name is hard to understand.
maybe 'pass internalModels to createStore based on arity'
|
fun fun Error: The addon `ember-cli-htmlbars` requires the npm package `ember-cli` to be above 0.1.2, but you have undefined. |
|
Hmm. Can you double check and confirm we have [email protected]? I released a bad patch release earlier (1.3.1)... |
|
@rwjblue the issue did start with 1.3.2 but it appears to not be the fault of 1.3.2. Something either in the dep checker/ember-cli or blueprint-test helpers is causing the grief. I got a few other things to do this morning, then I'll debug further. |
|
@rwjblue TL;DR These tests https://github.com/emberjs/data/blob/master/node-tests/blueprints/transform-test.js#L45 create a project at I believe modifyPackages may not be working correctly.. |
stefanpenner
force-pushed
the
remove-change-removes
branch
from
8d86899 to
b4c7a48
Compare
stefanpenner
force-pushed
the
remove-change-removes
branch
5 times, most recently
from
258f158 to
dd08392
Compare
stefanpenner
force-pushed
the
remove-change-removes
branch
from
dd08392 to
410fa36
Compare
stefanpenner
force-pushed
the
remove-change-removes
branch
from
1d60d8e to
a36a44f
Compare
|
finally green, although appveyor test are still hanging (unrelated to this PR, but I think we know whatsup in ember-cli land causing this...) |
When possible we should create new record arrays with there content, rather then creating them, and later adding there content. This prevents un-needed change events from firing. Some Older API's make this a tad tricky, but modern usages should not be penalized.