Batch record arrays #4849
Merged
Batch record arrays #4849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
force-pushed
the
batch-record-arrays
branch
from
d8d72ab to
375590d
Compare
|
This is ready to review. |
|
on emberaddons.com prior to this change, we spend
after we do that in like 7ms:
by batching |
stefanpenner
commented
Mar 9, 2017
|
|
||
| To avoid thrashing, it only runs at most once per run loop. | ||
| let models = pending[modelName] = pending[modelName] || []; |
There was a problem hiding this comment.
this should happen after 100
|
|
||
| recordArrays.forEach(array => array._removeInternalModels([internalModel])); | ||
| Object.keys(pending).forEach(modelName => { | ||
| let work = pending[modelName].map(internalModel => { |
There was a problem hiding this comment.
internalModelsToBeProcessed
|
|
||
| // process adapterPopulatedRecordArrays | ||
| if (modelsToRemove.length > 0) { | ||
| this.removeFromRemainingRecordArrays(modelsToRemove); |
There was a problem hiding this comment.
rename to removeFromAdapterPopulatedRecordArrays
stefanpenner
force-pushed
the
batch-record-arrays
branch
from
375590d to
95d0eac
Compare
stefanpenner
force-pushed
the
batch-record-arrays
branch
from
95d0eac to
f48e473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
batch additions / updates to all record arrays
test in a real app (emberaddons.com, much faster no more n+1 arrayChange events when adding/updating recordArrays)
add tests to ensure no regression re reduced number of array change vents
restore test https://github.com/emberjs/data/pull/4849/files#diff-4663f105651a747eef0a3b68ae951fc3R285