Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Shorthand method fixes in adapter #4774

Merged
merged 1 commit into from
Jan 26, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions addon/adapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,7 @@ export default Ember.Object.extend({
import DS from 'ember-data';

export default DS.Adapter.extend({
findRecord: function(store, type, id, snapshot) {

findRecord(store, type, id, snapshot) {
return new Ember.RSVP.Promise(function(resolve, reject) {
Ember.$.getJSON(`/${type.modelName}/${id}`).then(function(data) {
resolve(data);
Expand Down Expand Up @@ -128,7 +127,7 @@ export default Ember.Object.extend({
import DS from 'ember-data';

export default DS.Adapter.extend({
findAll: function(store, type, sinceToken) {
findAll(store, type, sinceToken) {
var query = { since: sinceToken };
return new Ember.RSVP.Promise(function(resolve, reject) {
Ember.$.getJSON(`/${type.modelName}`, query).then(function(data) {
Expand Down Expand Up @@ -159,7 +158,7 @@ export default Ember.Object.extend({
import DS from 'ember-data';

export default DS.Adapter.extend({
query: function(store, type, query) {
query(store, type, query) {
return new Ember.RSVP.Promise(function(resolve, reject) {
Ember.$.getJSON(`/${type.modelName}`, query).then(function(data) {
resolve(data);
Expand Down Expand Up @@ -197,7 +196,7 @@ export default Ember.Object.extend({
import Ember from 'ember';

export default DS.Adapter.extend(DS.BuildURLMixin, {
queryRecord: function(store, type, query) {
queryRecord(store, type, query) {
return new Ember.RSVP.Promise(function(resolve, reject) {
Ember.$.getJSON(`/${type.modelName}`, query).then(function(data) {
resolve(data);
Expand Down Expand Up @@ -236,7 +235,7 @@ export default Ember.Object.extend({
import { v4 } from 'uuid';

export default DS.Adapter.extend({
generateIdForRecord: function(store, inputProperties) {
generateIdForRecord(store, inputProperties) {
return v4();
}
});
Expand All @@ -260,7 +259,7 @@ export default Ember.Object.extend({
import DS from 'ember-data';

export default DS.Adapter.extend({
createRecord: function(store, type, snapshot) {
createRecord(store, type, snapshot) {
var data = this.serialize(snapshot, { includeId: true });
var url = `/${type.modelName}`;

Expand Down Expand Up @@ -290,7 +289,7 @@ export default Ember.Object.extend({
import DS from 'ember-data';

export default DS.Adapter.extend({
createRecord: function(store, type, snapshot) {
createRecord(store, type, snapshot) {
var data = this.serialize(snapshot, { includeId: true });

return new Ember.RSVP.Promise(function(resolve, reject) {
Expand Down Expand Up @@ -338,7 +337,7 @@ export default Ember.Object.extend({
import DS from 'ember-data';

export default DS.Adapter.extend({
updateRecord: function(store, type, snapshot) {
updateRecord(store, type, snapshot) {
var data = this.serialize(snapshot, { includeId: true });
var id = snapshot.id;

Expand Down Expand Up @@ -379,7 +378,7 @@ export default Ember.Object.extend({
import DS from 'ember-data';

export default DS.Adapter.extend({
deleteRecord: function(store, type, snapshot) {
deleteRecord(store, type, snapshot) {
var data = this.serialize(snapshot, { includeId: true });
var id = snapshot.id;

Expand Down Expand Up @@ -490,7 +489,7 @@ export default Ember.Object.extend({
write:

```javascript
shouldReloadRecord: function(store, ticketSnapshot) {
shouldReloadRecord(store, ticketSnapshot) {
var timeDiff = moment().diff(ticketSnapshot.attr('lastAccessedAt'), 'minutes');
if (timeDiff > 20) {
return true;
Expand Down Expand Up @@ -538,7 +537,7 @@ export default Ember.Object.extend({
write:

```javascript
shouldReloadAll: function(store, snapshotArray) {
shouldReloadAll(store, snapshotArray) {
var snapshots = snapshotArray.snapshots();

return snapshots.any(function(ticketSnapshot) {
Expand Down Expand Up @@ -592,7 +591,7 @@ export default Ember.Object.extend({
`shouldBackgroundReloadRecord` as follows:

```javascript
shouldBackgroundReloadRecord: function(store, snapshot) {
shouldBackgroundReloadRecord(store, snapshot) {
var connection = window.navigator.connection;
if (connection === 'cellular' || connection === 'none') {
return false;
Expand Down Expand Up @@ -631,7 +630,7 @@ export default Ember.Object.extend({
`shouldBackgroundReloadAll` as follows:

```javascript
shouldBackgroundReloadAll: function(store, snapshotArray) {
shouldBackgroundReloadAll(store, snapshotArray) {
var connection = window.navigator.connection;
if (connection === 'cellular' || connection === 'none') {
return false;
Expand Down