Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecate arguments #4760

Merged
merged 2 commits into from
Jan 23, 2017
Merged

Update deprecate arguments #4760

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c87b07
Update deprecate arguments
Jan 18, 2017
9302f6d
Update store.js
Jan 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions addon/-private/system/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1783,7 +1783,7 @@ Store = Service.extend({
@return {boolean}
*/
recordIsLoaded(modelName, id) {
deprecate(`Use of recordIsLoaded is deprecated, use hasRecordForId instead.`, {
deprecate(`Use of recordIsLoaded is deprecated, use hasRecordForId instead.`, true, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be false not true. These deprecations (AFAICT) are never being triggered.

deprecate('foo', true, { id: 'asdf', until: 'asdf'}) doesn't actually deprecate anything, but deprecate('foo', false, { id: 'asdf', until: 'asdf'}) does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwjblue That's correct.

id: 'ds.store.recordIsLoaded',
until: '3.0'
});
Expand Down Expand Up @@ -2617,15 +2617,15 @@ Store = Service.extend({
},

lookupAdapter(name) {
deprecate(`Use of lookupAdapter is deprecated, use adapterFor instead.`, {
deprecate(`Use of lookupAdapter is deprecated, use adapterFor instead.`, true, {
id: 'ds.store.lookupAdapter',
until: '3.0'
});
return this.adapterFor(name);
},

lookupSerializer(name) {
deprecate(`Use of lookupSerializer is deprecated, use serializerFor instead.`, {
deprecate(`Use of lookupSerializer is deprecated, use serializerFor instead.`, true, {
id: 'ds.store.lookupSerializer',
until: '3.0'
});
Expand Down