[SUPER WIP] Relationship State Overhaul #4726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this part of Single Source of Truth? |
|
@BryanCrotaz I believe this is just general relationship cleanup, preventing duplicate work and stuff. |
|
@BryanCrotaz @stefanpenner no, but it gets us closer to being able to implement it cleanly. |
|
A better version of this work is in #4882 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginnings of revisiting the objects / patterns used to manage the relationship layer in ember-data.
Relationshipas an abstract base classBelongsToRelationshipclassImplictRelationshipclassHasManyRelationshipclass-- potential changes for this effort that may be bumped to a second PR after this one --
ManyArray(upgradedHasManyRelationshipshould be able to handle this entirely)ArrayProxyfor a more custom solution.Current HasMany Complexity
