Removes Ember.K from codebase #4670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locks
force-pushed
the
remove-ember-k
branch
2 times, most recently
from
34225a5 to
1dc7198
Compare
locks
force-pushed
the
remove-ember-k
branch
from
1dc7198 to
e8e2b99
Compare
locks
force-pushed
the
remove-ember-k
branch
from
e8e2b99 to
c6d58ae
Compare
sduquej
added a commit
to sduquej/data
that referenced
this pull request
Nov 20, 2016
This slipped in emberjs#4670
cibernox
reviewed
Nov 20, 2016
| @@ -1,4 +1,4 @@ | |||
| /*eslint no-unused-vars: ["error", { "varsIgnorePattern": "(adam|dave|cersei)" }]*/ | |||
| 3/*eslint no-unused-vars: ["error", { "varsIgnorePattern": "(adam|dave|cersei)" }]*/ | |||
There was a problem hiding this comment.
A bit late, but there is a number here 👀
There was a problem hiding this comment.
I had actually fixed this and "pushed", but I forgot to actually git add the file so it was in the commit… Thanks @sduquej :)
There was a problem hiding this comment.
😅 It was also a bit too late when I saw it. @locks 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.