Warn when the JSONAPISerializer is extended with the EmbeddedRecordsM… #4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 22, 2016
| @@ -500,6 +500,11 @@ const JSONAPISerializer = JSONSerializer.extend({ | |||
|
|
|||
| runInDebug(function() { | |||
| JSONAPISerializer.reopen({ | |||
| willMergeMixin(props) { | |||
| warn('The JSONAPISerializer does not work with the EmbeddedRecordsMixin because the JSON API spec does not describe how to format embedded resources.', !props .isEmbeddedRecordsMixin, { | |||
There was a problem hiding this comment.
There is a superfluous whitespace in !props .isEmbeddedRecordsMixin...
|
LGTM 👍 |
bmac
force-pushed
the
warn-with-embedded-mixin
branch
2 times, most recently
from
14ce322 to
ad4a208
Compare
bmac
force-pushed
the
warn-with-embedded-mixin
branch
from
ad4a208 to
41b0ad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ixin