Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Use correct version number when used as an addon. #4064

Closed
wants to merge 3 commits into from

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jan 12, 2016

No description provided.

@fivetanley
Copy link
Member

git-repo-version is still being used in other files, probably needs to be replaced with calculateVersion instead.

@fivetanley
Copy link
Member

This code (not the fault of this PR) is also appending v to versions, as in v2.3.0, making it show up as v2.3.0 when it should show up as 2.3.0 in Ember.libraries and DS.VERSION. Might also be nice to stick that in calculateVersion

@rwjblue
Copy link
Member Author

rwjblue commented Jan 12, 2016

Closed in favor of #4066

@rwjblue rwjblue closed this Jan 12, 2016
@rwjblue rwjblue deleted the use-proper-version-as-addon branch January 12, 2016 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants