Strip stuff from addon before it is added to app

[pangratz]

Currently the code of the ember-data addon is added to the app. This is problematic since the code contains assert, debug, etcetera calls and also no feature flag code is stripped.

This PR is my stab at fixing this, so only the stripped code is added via the treeForAddon hook in index.js.

This addresses #4047 and takes inspiration from @fivetanley's gist.

---

TODO

• Check if this works as expected
• Only strip debug statements imported from ember-data/-private/debug if environment === "production"? Currently the statements are always stripped.
• Correctly strip features which have a value other than true in config/features.json. will be addressed in an upcoming PR

[pangratz]

Ok, so I tested this locally:

# checkout ember-data from PR and link to npm
git clone https://github.com/emberjs/data.git
cd data
hub checkout https://github.com/emberjs/data/pull/4048
npm link

# create new ember app using linked ember-data
cd ..
ember new my-app --skip-bower --skip-npm
cd my-app
bower install
bower uninstall ember-data --save
bower install ember-cli/ember-cli-shims#0.1.0 --save
npm link ember-data
npm install

# create build and check if dist/assets/vendor.js contains correctly stripped ember-data
ember build

All the debug statements from ember-data/-private/debug are correctly stripped (and the feature-flagged stuff is still present behind if(isEnabled("ds-xxx")) {}, which is expeceted).

There is a problem though: all the ember-data modules in dist/assets/vendor.js are inside additional define('ember-data/xxx', ...) calls (see full vendor.js):

define('ember-data/-private/adapters/build-url-mixin', function () {

  'use strict';

  define('ember-data/-private/adapters/build-url-mixin', ['exports', 'ember'], function (exports, _ember) {

    var get = _ember['default'].get;

    // ...
  });

});

---

EDIT: the problem has been fixed with help from the sharp eyes of @rwjblue.

[rwjblue]

if (process.env.EMBER_ENV !== 'production') {
  var strippedAddonCode = strippedBuild('ember-data', dir, {
    blacklist: ['es6.modules', 'useStrict']
  });

  return this._super.treeForAddon.call(this, strippedAddonCode);
} else {
  return this._super.treeForAddon.call(this, merge([version(), dir]));
}

[pangratz]

🙏

[rwjblue]

This looks good to me, and I'd like to see this land even without the features.json work done. The debug statement stripping in production will affect [email protected] when we release it, but since 2.3.x doesn't include features yet the features.json portion does not have an impact on 2.3.0.

Thoughts on landing this into beta, and iterating on it for 2.4.0-beta.x series for the feature flag stripping?

[bmac]

@pangratz do you mind squashing these commits and prefix the commit message with [BUGFIX beta]

[eriktrom]

@pangratz - this doesn't work unless the following are moved to dependencies (instead of devDependencies) - at least that's what I found (im using ember-cli-deploy though)

Here's a compare: https://github.com/pangratz/data/compare/fix-ember-addon-production...eriktrom:fix-ember-addon-production

Otherwise, looks good and works for me

Thanks for tackling this

[pangratz]

Awesome catch @eriktrom! Thanks for testing!

Looks like a ember build --prod also doesn't work when the dependencies are only available in devDependencies. I've updated this PR to move the dependencies which are needed for a ember build --prod into dependencies and now it works:

ember new my-app --skip-bower --skip-npm
cd my-app
bower install
bower uninstall ember-data --save
bower install ember-cli/ember-cli-shims#0.1.0 --save
npm install pangratz/data#fix-ember-addon-production
npm install

ember build --prod

[bmac]

Thanks @pangratz and @eriktrom