Run ember watson: methodify on addon/ and test/
#3926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,7 +49,7 @@ export default Ember.Mixin.create({ | |||
| @param {Object} query object of query parameters to send for query requests. | |||
| @return {String} url | |||
| */ | |||
| buildURL: function(modelName, id, snapshot, requestType, query) { | |||
| buildURL(modelName, id, snapshot, requestType, query) { | |||
There was a problem hiding this comment.
I'm not a big fan of the concise method definitions because I find it makes it harder to search for the method definition in a file.
That said, if others prefer this syntax I don't want to stand in the way of it being merged. cc @igorT @wecc @fivetanley
|
Hi @seanpdoyle, can you rerun the commands? There are merge conflicts, but we agreed to merge this. |
Convert function declaration into ES6 syntax.
Convert to ES6 function declarations in tests.
seanpdoyle
force-pushed
the
sd-ember-watson
branch
from
f4f869c to
9a57fa0
Compare
fivetanley
added a commit
that referenced
this pull request
Dec 2, 2015
Run `ember watson: methodify` on `addon/` and `test/`
|
👍 it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CLEANUP]
ember watson:methodify addon/Convert function declaration into ES6 syntax.
[CLEANUP]
ember watson:methodify tests/Convert to ES6 function declarations in tests.