[perf] minor adjustments to store#push flow
#3889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should prefer Array.isArray over Ember.isArray as the later is merely an alias for the former and exists for compar |
| var internalModels = data.data.map((recordData) => this._pushInternalModel(recordData)); | ||
| return internalModels.map((internalModel) => internalModel.getRecord()); | ||
| if (isArray(data.data)) { | ||
| var internalModels = []; |
|
Two comments otherwise this Lgtm |
trentmwillis
force-pushed
the
push-perf
branch
from
a3fa3bc to
64547e2
Compare
|
@stefanpenner updated, looks like AppVeyor had issues with installing node modules though |
|
@trentmwillis silly appveyor... anyways thanks this looks good to me. Its really sad that |
stefanpenner
added a commit
that referenced
this pull request
Oct 26, 2015
[perf] minor adjustments to `store#push` flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some simple suggestions of refactoring to squeeze out a little extra performance when calling
store#push. In our application this shows ~50ms improvement for slower devices on medium-sized payloads. Changes are as follows:coerceIdin_loadsince it gets called in_internalModelForIdEmber.isArrayinstead ofEmber.typeOffor-loops instead ofArray.prototypemethods