Merge normalizeRelationships and setupRelationships methods in store

[trentmwillis]

While working on some performance related tasks, I noticed that normalizeRelationships and setupRelationships both loop over the relationships for a record. The only time these functions are used is in sequence, so it looks like these could be merged to cut down on some time complexity.

Will be trying this out in our application tomorrow to see if it has any side effects, but it doesn't appear to so far.

[tchak]

LGTM 👍

[trentmwillis]

Any chance this could get merged? Just updated to remove the type param (not sure it was needed to begin with).

[wecc]

@igorT r?

[igorT]

can we normalize here, and put the comment from 1727 back in?

[trentmwillis]

I can, but not sure I see the point in doing that. If we normalize here, then we will have to check that value exists and the kind of relationship in two places (here and then again below).

[igorT]

Mostly for code readability/place to put the deleted comment/ease of
understanding
On Oct 22, 2015 10:04, "Trent Willis" [email protected] wrote:

In packages/ember-data/lib/system/store.js
#3854 (comment):

@@ -2135,13 +2108,16 @@ function setupRelationships(store, record, data) {
relationship = record._relationships.get(key);
relationship.updateMeta(data.relationships[key].meta);
}
+
var value = data.relationships[key].data;

I can, but not sure I see the point in doing that. If we normalize here,
then we will have to check that value exists and the kind of relationship
in two places (here and then again below).

—
Reply to this email directly or view it on GitHub
https://github.com/emberjs/data/pull/3854/files#r42775635.

[igorT]

👍 after the small refactor. Thanks for the PR

[trentmwillis]

@igorT updated. Let me know if there's anything else.

[bmac]

Thanks @trentmwillis. I have rebased this pr and merged is as 828f8ea.