update coalesceFindRequests doc for JSONAPIAdapter #3770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| comments: [1, 2] | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Do you mind adding a new line after all these code block sections? The markdown parser for the api docs doesn't format these sections correctly without the new line to separate content after the code block.
There was a problem hiding this comment.
Yep, sorry about that, I lost the newlines in copying and pasting.
|
Looks like travis is now complaining about trailing white space in the new docs. Do you mind fixing that and then squashing everything into 1 commit? |
Conflicts: packages/ember-data/lib/adapters/json-api-adapter.js
|
Still working on squashing the commits into one, made a mistake (still a little new to git) |
Conflicts: packages/ember-data/lib/adapters/json-api-adapter.js
|
Closing because I messed up the squashing so badly I don't know how to make it happen. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the JSONAPIAdapter sends different query params then the RESTAPIAdapter, so took a stab at updating the documentation. I felt it was better to put the info in the json-api-adapter.js rather than putting a "if you're using JSONAPIAdapter" statement into the rest-adapter.js. I did override the coalesceFindRequests bool in json-api-adapter.js, but let me know if this is not the desired way to do things at this point.