Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Remove deprecation warning for dev, keep IE 8 compat #3475

Merged
merged 1 commit into from
Jul 2, 2015
Merged

[BUGFIX release] Remove deprecation warning for dev, keep IE 8 compat #3475

merged 1 commit into from
Jul 2, 2015

Conversation

sly7-7
Copy link
Contributor

@sly7-7 sly7-7 commented Jul 1, 2015

@wecc
Copy link
Contributor

wecc commented Jul 1, 2015

Would it make sense to export create and keysFunc from a separate module and import instead of having Object.create || Ember.create / Object.keys || Ember.keys everywhere?

@sly7-7
Copy link
Contributor Author

sly7-7 commented Jul 2, 2015

@wecc Not sure if it's worth it, but it maybe be good for further refactorings.

@bmac
Copy link
Member

bmac commented Jul 2, 2015

Looks good to me. I think the build failure might be fixed by 6f1a6f8. I can cherry pick that over to the release branch in the morning when I'm on my laptop.

@sly7-7
Copy link
Contributor Author

sly7-7 commented Jul 2, 2015

@bmac I cherry picked your commit in that branch and force pushed. Now failing for a good reason.

@sly7-7
Copy link
Contributor Author

sly7-7 commented Jul 2, 2015

@bmac, instead I've created #3478 with your fix, and also update tests here (we can't import modules in tests)

bmac added a commit that referenced this pull request Jul 2, 2015
[BUGFIX release] Remove deprecation warning for dev, keep IE 8 compat
@bmac bmac merged commit 595ae16 into emberjs:release Jul 2, 2015
@sly7-7 sly7-7 deleted the fix-deprecated-ember-keys branch July 2, 2015 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants