Register service:store in an initializer instead of an instanceInitia… #3349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmac
added a commit
that referenced
this pull request
Jun 16, 2015
Register service:store in an initializer instead of an instanceInitia…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lizer
This fixes #3342.
Basically it moves the registering of
service:storeinto an initializer so users don't need to worry about making sure their instance initializers are run after theember-datainstance initializer.The reason why we didn't do this initially is because it causes extra deprecation warnings when users try load custom stores from
app/store.jsorapp/stores/application.js.Custom Store in
app/store.js(Deprecated Path 1)Custom Store in
app/stores/application.js(Deprecated Path 2)Custom Store in
app/services/store.js(Happy Path)