Convert unload test to json api format for store.push.. #3223
#3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,7 +18,7 @@ var shouldNotContain = function(array, item) { | |||
|
|
|||
| module("integration/filter - DS.Model updating", { | |||
| setup: function() { | |||
| array = [{ id: 1, name: "Scumbag Dale", bestFriend: 2 }, { id: 2, name: "Scumbag Katz" }, { id: 3, name: "Scumbag Bryn" }]; | |||
| array = [{ "id": "1", "type": "person", "attributes": { "name": "Scumbag Dale", "bestFriend": "2" } }, { "id": "2", "type": "person", "attributes": { "name": "Scumbag Katz" } }, { "id": 3, "type": "person", "attributes": { "name": "Scumbag Bryn" } }]; | |||
There was a problem hiding this comment.
I think bestFriend should be a relationship here
|
Would you mind squashing the commits and remove "WIP"? |
andrejunges
force-pushed
the
master
branch
4 times, most recently
from
a282502 to
816d0b0
Compare
andrejunges
changed the title
store.push.. #3223store.push.. #3223
| "attributes": { | ||
| "name": "Scumbag Dale" | ||
| }, | ||
| relationships: { |
There was a problem hiding this comment.
Could you encapsulate all of the keys in quotes, for consistency?
There was a problem hiding this comment.
Perhaps the quoted keys should be unquoted instead @wecc?
|
Can you prefix the commit with [CLEANUP beta]? |
andrejunges
force-pushed
the
master
branch
3 times, most recently
from
74bef67 to
0eadbbe
Compare
wecc
added a commit
that referenced
this pull request
Jun 25, 2015
Convert unload test to json api format for `store.push`.. #3223
|
Thank you so much! |
|
👍 Awesome work @andrejunges! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will break some tests, but now the the calls to store.push are
using jsonApiFormat