lookup JSONSerializer instance through store instead of manual instan… #3211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetanley
force-pushed
the
fix-to-json-on-models
branch
from
e81023d to
2a90daa
Compare
fivetanley
force-pushed
the
fix-to-json-on-models
branch
from
2a90daa to
8106107
Compare
fivetanley
added a commit
that referenced
this pull request
Jun 5, 2015
lookup JSONSerializer instance through store instead of manual instan…
| @@ -375,7 +374,7 @@ var Model = Ember.Object.extend(Ember.Evented, { | |||
| */ | |||
| toJSON: function(options) { | |||
| // container is for lazy transform lookups | |||
| var serializer = JSONSerializer.create({ container: this.container }); | |||
| var serializer = this.store.serializerFor('-default'); | |||
There was a problem hiding this comment.
@fivetanley Good change! Would it be possible to do something like store.serializerFor(this.constructor.typeKey) instead? To get the record-specific serializer when one is available.
We've had this work-around for a long time (code not aligned with recent ED, but it shows the main idea):
toJSON: function(options) {
var serializer = this.store.serializerFor(this.constructor.typeKey);
return serializer.serialize(this, options);
}
There was a problem hiding this comment.
no, if you want the record specific serializer, you record.serialize(). toJSON is using the json serializer for debugging and similar purposes
There was a problem hiding this comment.
You are right, thanks! My workaround was old, I see now that the issue I worked around has been solved for ~2 years 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tiation