-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ember Data should delegate to the container to normalize the type key. #2766
Closed
+11
−10
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,6 @@ import { | |
InvalidError, | ||
Adapter | ||
} from "ember-data/system/adapter"; | ||
import { singularize } from "ember-inflector/system/string"; | ||
import { | ||
Map | ||
} from "ember-data/system/map"; | ||
|
@@ -77,8 +76,6 @@ var Promise = Ember.RSVP.Promise; | |
var copy = Ember.copy; | ||
var Store; | ||
|
||
var camelize = Ember.String.camelize; | ||
|
||
// Implementors Note: | ||
// | ||
// The variables in this file are consistently named according to the following | ||
|
@@ -1777,7 +1774,11 @@ Store = Ember.Object.extend({ | |
@return {String} if the adapter can generate one, an ID | ||
*/ | ||
_normalizeTypeKey: function(key) { | ||
return camelize(singularize(key)); | ||
// Delegate to the container for normalization. The container | ||
// requires a ':' to normalize so we add `model:` then slice off | ||
// the first 6 characters to remove the `model:` in the return | ||
// value | ||
return this.container.normalize('model:' + key).slice(6); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @stefanpenner Is there a better way go get the normalized value for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not currently :( |
||
} | ||
}); | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make a
rootForType
function to generate this root namespace based on the type key.