Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT CI] Fastboot and IE11 Integration Tests #6431

Closed
4 tasks done
runspired opened this issue Sep 11, 2019 · 3 comments · Fixed by #6831
Closed
4 tasks done

[FEAT CI] Fastboot and IE11 Integration Tests #6431

runspired opened this issue Sep 11, 2019 · 3 comments · Fixed by #6831
Labels
Infra/CI/DX

Comments

@runspired
Copy link
Contributor

runspired commented Sep 11, 2019 •
edited
Loading

We should test the following

IE11

  • run all tests with jQuery
  • run all tests without jQuery

Fastboot

  • run all tests with jQuery
  • run all tests without jQuery
@runspired runspired mentioned this issue Sep 11, 2019
Closed
28 tasks
@runspired
Copy link
Contributor Author

#6459 introduces an approach for having private packages that are fully functioning apps we can use to test with.

We should use this approach to build the above fastboot scenarios, we can use ember-try to switch between jquery and non-jquery test runs without a single test app.

For the IE11 tests we should just run our existing test suite in an IE11 box both with and without jQuery using ember-try

@Gaurav0 Gaurav0 mentioned this issue Sep 30, 2019
Merged
@Gaurav0
Copy link
Contributor

Gaurav0 commented Nov 21, 2019

Turning on jQuery during Fastboot doesn't make sense, jQuery doesn't run in node.

@runspired
Copy link
Contributor Author

@Gaurav0 if you have it on we use najax, if you don't we use fetch

@runspired runspired mentioned this issue Dec 2, 2019
Merged
runspired added a commit that referenced this issue Dec 3, 2019
@runspired
[BUGFIX TESTS] matrix tests for fastboot & ie11 w/jquery & fetch (#6831)
4837e5a 
resolves #6431

Bugfix: jQuery+fastboot

The added tests for fastboot revealed that fastboot+jQuery was broken because our computed property for getting the fastboot service wasn't setting and updating it's value properly leading to it always being false. This led us down the wrong code-path and ultimately meant that the url we provided to najax wasn't parsed correctly and would error.
@runspired runspired added Infra/CI/DX and removed CI labels Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Infra/CI/DX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX TESTS] matrix tests for fastboot & ie11 w/jquery & fetch emberjs/data
2 participants
@Gaurav0 @runspired