Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] replace mocha-only-detector with eslint rule for use of .only #6109

Closed
runspired opened this issue May 14, 2019 · 0 comments · Fixed by #6125
Closed

[CHORE] replace mocha-only-detector with eslint rule for use of .only #6109

runspired opened this issue May 14, 2019 · 0 comments · Fixed by #6125

Comments

@runspired
Copy link
Contributor

Current we use the mocha-only-detector package to prevent usage of .only in tests. We should replace this in favor of an eslint plugin that fails for such usage.
@runspired runspired mentioned this issue May 14, 2019
Merged
makepanic added a commit to makepanic/data that referenced this issue May 20, 2019
@makepanic
chore: replace mocha-only-detector with mocha/no-exclusive-tests …
cc9adf4 
…rule

fixes emberjs#6109
makepanic added a commit to makepanic/data that referenced this issue May 20, 2019
@makepanic
chore: replace mocha-only-detector with mocha/no-exclusive-tests …
88850dc 
…rule

fixes emberjs#6109
@makepanic makepanic mentioned this issue May 20, 2019
Merged
runspired pushed a commit that referenced this issue May 22, 2019
@makepanic @runspired
[CHORE tests] replace mocha-only-detector with `mocha/no-exclusive-…
9f995ec 
…tests` rule (#6125)

fixes #6109
pete-the-pete pushed a commit to pete-the-pete/data that referenced this issue Jul 23, 2019
@makepanic
[CHORE tests] replace mocha-only-detector with `mocha/no-exclusive-…
8d26f81 
…tests` rule (emberjs#6125)

fixes emberjs#6109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: replace mocha-only-detector with mocha/no-exclusive-tests rule makepanic/data
1 participant
@runspired