-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ember-data 2.14.0: 'instrument' is imported from external module 'ember-data/-debug' but never used #5016
Comments
Likely this means that linting is running before transpilation completes. |
FWIW, linting should always be ran before transpilation. I guarantee that babels transpiled output would not pass most apps linting rules. 😃 |
@rwjblue all of our instrument import locations are used. This suggests to me that linting occurs after something strips the usage but before another transform strips the left-behind import itself. |
This is not a linting error. This is a rollup thing. |
This is almost certainly because we run things through babel before passing them to |
@rwjblue we have a babel plugin to strip pre-rollup, but it only runs in prod. Heimdall though is stripped all the time unless the flag is set. Might just need to reconfigure this to avoid polluting folks with this error. |
Same Issue. What's the way to fix this? |
I'm seeing this in [email protected] |
Seeing the same in [email protected] when running 'ember server' on brand new application on brand new installation of node and ember:
|
This error will not do any harm to your application, and it has been fixed in [email protected]. Upcoming release of Ember CLI will include the fix. |
ember-cli: 2.14.0 'instrument' is imported from external module 'ember-data/-debug' but never used Still there ... |
* Update to remove bower dependency + Fastboot compatibility * Update to remove bower dependency + Fastboot compatibility * lock to 0.5.15 gmaps tag * Rerun tests * replace gmaps-for-apps github tag dependency with an npm module * add travis wait to npm install to fix emberjs/data#5016 * move travis wait to build script and allow beta fail * increase travis wait on build to 30 minutes for ember-lts-2.4
I can confirm that this warning is still displayed but only for development builds. ember-cli: 2.14.0 |
I'm using ruby on rails and the ember-rails gem which looks like this but with the error from OP since i also use pow and not ember serve (dont know if this would be possible with rails) i can't just add the -prod flag and forget about it. I'm trying to get ember and rails to run together since some hours and it seems like this bug is the last thing that is preventing me from using an ember app in my rails app |
Same problem: Anybody could fix it? All my projects were broken :( I tried install several version of ember-cli, but could not fixed it. |
@abbasovalex that error/warning shouldn't be able to halt your project. If that's happening it's most likely a different problem. If you're already part of the Ember Slack community, let's continue the conversation there. Otherwise get an invitation 👉 here |
Also getting this warning. ember-cli: 2.14.1 |
Getting the same error for dev env. version: 2.3.0 |
You mean warning right? |
I'm still seeing the same warning: ember -v I got this error when I upgraded ember-cli from 2.13.3 to 2.14.0. I changed next versions in package.json: Hope it helps. Do you have any estimation when this issue will be fixed? PS: I also got 2 different warnings after upgrade: But I guess it's not related to this issue. |
I have ember 2.3
…On Tue, Aug 8, 2017 at 7:59 AM, Vinchens00 ***@***.***> wrote:
I'm still seeing the same warning:
ember -v
ember-cli: 2.14.2
node: 6.10.0
os: darwin x64
I got this error when I updated ember-cli from 2.13.3 to 2.14.0. I changed
next versions in package.json:
ember-cli 2.13.3 -> 2.14.0
ember-cli-htmlbars: ^1.2.0 -> ^2.0.1
ember-cli-htmlbars-inline-precompile: ^0.4.0 -> ^0.4.3
ember-data: 2.13.2 -> 2.14.3
ember-source: 2.13.3 -> 2.14.0
Hope it helps.
Production build also shows this warning.
Do you have any estimation when this issue will be fixed?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5016 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AQavosGqqlF4VcPz6O6PEEx7Mf1UFrHyks5sWE21gaJpZM4N9dld>
.
|
ember 2.3.2 |
Same here.
|
Seeing this on a fresh ember app.
|
|
|
should be fixed by #5114 (which is pending some unit tests) |
@runspired said he would look to add tests tonight, once those land. We can backport and release :) |
Anyone resolve this? What's up with all these? ember-data/lib/stripped-build-plugins.js: uniqueAdd(filteredImports, 'ember-data/-debug', ['instrument']); Something not quite right about that. Is it suppose to be ember-data/broccoli-debug ? |
This has been fixed, we should close this issue |
Thanks @xomaczar. |
Launching application:
The text was updated successfully, but these errors were encountered: