explore stricter

emberjs · Aug 11, 2022 · c8fc274 · c8fc274
1 parent 91eb8b7
commit c8fc274
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/packages/record-data/addon/-private/graph/operations/update-relationship.ts b/packages/record-data/addon/-private/graph/operations/update-relationship.ts
@@ -35,6 +35,7 @@ export default function updateRelationshipOperation(graph: Graph, op: UpdateRela
         payload.data = [];
       }
       assert(`Expected an array`, Array.isArray(payload.data));
+      // TODO may not need to cast to stable identifiers here since update likely does this too
       graph.update(
         {
           op: 'replaceRelatedRecords',
@@ -45,6 +46,7 @@ export default function updateRelationshipOperation(graph: Graph, op: UpdateRela
         true
       );
     } else {
+      // TODO may not need to cast to stable identifiers here since update likely does this too
       graph.update(
         {
           op: 'replaceRelatedRecord',

diff --git a/packages/store/addon/-private/caches/instance-cache.ts b/packages/store/addon/-private/caches/instance-cache.ts
@@ -166,6 +166,7 @@ export class InstanceCache {
 
     this._storeWrapper = new RecordDataStoreWrapper(this.store);
     this.__recordDataFor = (resource: RecordIdentifier) => {
+      // TODO enforce strict
       const identifier = this.store.identifierCache.getOrCreateRecordIdentifier(resource);
       return this.getRecordData(identifier);
     };