chore: when types are private, remove exports entirely for v1 addons

emberjs · Mar 1, 2024 · 79b175a · 79b175a
1 parent 2a1e3d3
commit 79b175a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/release/core/publish/steps/generate-tarballs.ts b/release/core/publish/steps/generate-tarballs.ts
@@ -108,7 +108,13 @@ function scrubTypesFromExports(pkg: Package) {
 
 async function makeTypesPrivate(pkg: Package) {
   // scrub the package.json of any types fields in exports
-  scrubTypesFromExports(pkg);
+  // when the types are private, we completely remove the exports field
+  // to avoid issues with embroider, auto-import and v1 addons
+  if (pkg.pkgData['ember-addon']?.version === 1) {
+    delete pkg.pkgData.exports;
+  } else {
+    scrubTypesFromExports(pkg);
+  }
 
   // remove @warp-drive/core-types from dependencies and peerDependencies
   delete pkg.pkgData.dependencies?.['@warp-drive/core-types'];

diff --git a/release/utils/package.ts b/release/utils/package.ts
@@ -55,6 +55,11 @@ export type PACKAGEJSON = {
   scripts?: Record<string, string>;
   files?: string[];
   exports?: ExportConfig;
+  'ember-addon'?: {
+    main?: 'addon-main.js';
+    type?: 'addon';
+    version?: 1 | 2;
+  };
 };
 
 export type APPLIED_STRATEGY = {