fix nightly.yml (#6857)

* fix nightly.yml

* add pull request event

* more fixes

* remove pull request trigger for nightly job

* fix lint

* Revert "remove pull request trigger for nightly job"

This reverts commit decbf7d.

* Revert "Revert "remove pull request trigger for nightly job""

This reverts commit 3290ad5.

.github/workflows/nightly.yml

@@ -3,15 +3,9 @@ name: 'Nightly'
 on:
   schedule:
     - cron: '* 14 * * *' # 14:00 in UTC is 6am PST
-    branches:
-      - master
 
 jobs:
   test-all-deprecations:
-    strategy:
-      fail-fast: false
-      matrix:
-        scenario: [ember-beta, ember-canary]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v1

packages/unpublished-adapter-encapsulation-test-app/testem.js

@@ -1,9 +1,20 @@
+// eslint-disable-next-line node/no-unpublished-require
+const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');
+
+const TestIE = process.env.TEST_IE11;
+
+if (TestIE) {
+  // eslint-disable-next-line no-console
+  console.log('\n\nLaunching with IE\n\n');
+}
+
 module.exports = {
   test_page: 'tests/index.html?hidepassed',
   disable_watching: true,
-  reporter: 'dot',
-  launch_in_ci: ['Chrome'],
+  reporter: customDotReporter,
+  launch_in_ci: TestIE ? ['IE'] : ['Chrome'],
   launch_in_dev: ['Chrome'],
+  browser_start_timeout: 120,
   browser_args: {
     Chrome: {
       ci: [

packages/unpublished-debug-encapsulation-test-app/testem.js

@@ -1,9 +1,20 @@
+// eslint-disable-next-line node/no-unpublished-require
+const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');
+
+const TestIE = process.env.TEST_IE11;
+
+if (TestIE) {
+  // eslint-disable-next-line no-console
+  console.log('\n\nLaunching with IE\n\n');
+}
+
 module.exports = {
   test_page: 'tests/index.html?hidepassed',
   disable_watching: true,
-  reporter: 'dot',
-  launch_in_ci: ['Chrome'],
+  reporter: customDotReporter,
+  launch_in_ci: TestIE ? ['IE'] : ['Chrome'],
   launch_in_dev: ['Chrome'],
+  browser_start_timeout: 120,
   browser_args: {
     Chrome: {
       ci: [

packages/unpublished-fastboot-test-app/testem.js

@@ -1,8 +1,18 @@
+// eslint-disable-next-line node/no-unpublished-require
+const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');
+
+const TestIE = process.env.TEST_IE11;
+
+if (TestIE) {
+  // eslint-disable-next-line no-console
+  console.log('\n\nLaunching with IE\n\n');
+}
+
 module.exports = {
   test_page: 'tests/index.html?hidepassed',
   disable_watching: true,
-  reporter: 'dot',
-  launch_in_ci: ['Chrome'],
+  reporter: customDotReporter,
+  launch_in_ci: TestIE ? ['IE'] : ['Chrome'],
   launch_in_dev: ['Chrome'],
   browser_start_timeout: 120,
   browser_args: {

packages/unpublished-model-encapsulation-test-app/testem.js

@@ -1,9 +1,20 @@
+// eslint-disable-next-line node/no-unpublished-require
+const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');
+
+const TestIE = process.env.TEST_IE11;
+
+if (TestIE) {
+  // eslint-disable-next-line no-console
+  console.log('\n\nLaunching with IE\n\n');
+}
+
 module.exports = {
   test_page: 'tests/index.html?hidepassed',
   disable_watching: true,
-  reporter: 'dot',
-  launch_in_ci: ['Chrome'],
+  reporter: customDotReporter,
+  launch_in_ci: TestIE ? ['IE'] : ['Chrome'],
   launch_in_dev: ['Chrome'],
+  browser_start_timeout: 120,
   browser_args: {
     Chrome: {
       ci: [

packages/unpublished-record-data-encapsulation-test-app/testem.js

@@ -1,9 +1,20 @@
+// eslint-disable-next-line node/no-unpublished-require
+const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');
+
+const TestIE = process.env.TEST_IE11;
+
+if (TestIE) {
+  // eslint-disable-next-line no-console
+  console.log('\n\nLaunching with IE\n\n');
+}
+
 module.exports = {
   test_page: 'tests/index.html?hidepassed',
   disable_watching: true,
-  reporter: 'dot',
-  launch_in_ci: ['Chrome'],
+  reporter: customDotReporter,
+  launch_in_ci: TestIE ? ['IE'] : ['Chrome'],
   launch_in_dev: ['Chrome'],
+  browser_start_timeout: 120,
   browser_args: {
     Chrome: {
       ci: [

packages/unpublished-relationship-performance-test-app/testem.js

@@ -1,20 +1,31 @@
+// eslint-disable-next-line node/no-unpublished-require
+const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');
+
+const TestIE = process.env.TEST_IE11;
+
+if (TestIE) {
+  // eslint-disable-next-line no-console
+  console.log('\n\nLaunching with IE\n\n');
+}
+
 module.exports = {
   test_page: 'tests/index.html?hidepassed',
   disable_watching: true,
-  launch_in_ci: ['Chrome'],
+  reporter: customDotReporter,
+  launch_in_ci: TestIE ? ['IE'] : ['Chrome'],
   launch_in_dev: ['Chrome'],
+  browser_start_timeout: 120,
   browser_args: {
     Chrome: {
       ci: [
-        // --no-sandbox is needed when running Chrome inside a container
-        process.env.CI ? '--no-sandbox' : null,
         '--headless',
         '--disable-dev-shm-usage',
         '--disable-software-rasterizer',
         '--mute-audio',
         '--remote-debugging-port=0',
         '--window-size=1440,900',
-      ].filter(Boolean),
+        '--no-sandbox',
+      ],
     },
   },
 };

packages/unpublished-serializer-encapsulation-test-app/testem.js

@@ -1,9 +1,20 @@
+// eslint-disable-next-line node/no-unpublished-require
+const customDotReporter = require('@ember-data/unpublished-test-infra/src/testem/custom-dot-reporter');
+
+const TestIE = process.env.TEST_IE11;
+
+if (TestIE) {
+  // eslint-disable-next-line no-console
+  console.log('\n\nLaunching with IE\n\n');
+}
+
 module.exports = {
   test_page: 'tests/index.html?hidepassed',
   disable_watching: true,
-  reporter: 'dot',
-  launch_in_ci: ['Chrome'],
+  reporter: customDotReporter,
+  launch_in_ci: TestIE ? ['IE'] : ['Chrome'],
   launch_in_dev: ['Chrome'],
+  browser_start_timeout: 120,
   browser_args: {
     Chrome: {
       ci: [