This repository has been archived by the owner on Aug 3, 2020. It is now read-only.
setOwner sets the container in Ember 1 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmun
force-pushed
the
better-setOwner-in-Ember-1
branch
from
699f9a2 to
4679b88
Compare
mmun
commented
May 15, 2020
| assert.ok(!!foo.get('session'), 'session injection exists'); | ||
| }); | ||
|
|
||
| test('[Ember 1.x]: setOwner does not crash if the owner does not have a container', function(assert) { |
There was a problem hiding this comment.
this isn't really testing anything important, just added it as a sanity check
rwjblue
previously requested changes
May 15, 2020
mmun
commented
May 15, 2020
mmun
force-pushed
the
better-setOwner-in-Ember-1
branch
2 times, most recently
from
332770c to
23c3949
Compare
mmun
force-pushed
the
better-setOwner-in-Ember-1
branch
from
23c3949 to
aeb1f67
Compare
rwjblue
approved these changes
May 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.