-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for the built-in components for routing/specifying-a-routes-model.md #699
Update docs for the built-in components for routing/specifying-a-routes-model.md #699
Conversation
@@ -86,33 +86,33 @@ method. | |||
|
|||
Note: A route with a dynamic segment will always have its `model` hook called when it is entered via the URL. | |||
If the route is entered through a transition (e.g. when using the [link-to](../../templates/links/) Handlebars helper), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the <LinkTo />
component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chancancode Looks like the relative link ../../templates/links/
is dead. Could you point me to the correct page? I am having trouble finding it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chancancode Looks like putting <LinkTo />
directly into the MD link box won't work. Because of this and that I couldn't find templates/links in the left nav, I assumed the link broke 🤣I had to put it in side back ticks to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for checking! 😱 Do you mind checking if the other PRs we merged lately have this problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chancancode I checked the recently closed PR's. I can confirm that none of them have this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
@@ -86,33 +86,33 @@ method. | |||
|
|||
Note: A route with a dynamic segment will always have its `model` hook called when it is entered via the URL. | |||
If the route is entered through a transition (e.g. when using the [link-to](../../templates/links/) Handlebars helper), | |||
and a model context is provided (second argument to `link-to`), then the hook is not executed. | |||
and a model context is provided (by passing in `@model` to `<LinkTo />`), then the hook is not executed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- model context -> model object
- I think we can just delete (by passing...)
No description provided.