Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for the built-in components for routing/specifying-a-routes-model.md #699

Merged
merged 2 commits into from
Mar 31, 2019

Conversation

Charizard
Copy link
Contributor

No description provided.

@@ -86,33 +86,33 @@ method.

Note: A route with a dynamic segment will always have its `model` hook called when it is entered via the URL.
If the route is entered through a transition (e.g. when using the [link-to](../../templates/links/) Handlebars helper),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the <LinkTo /> component

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chancancode Looks like the relative link ../../templates/links/ is dead. Could you point me to the correct page? I am having trouble finding it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chancancode Looks like putting <LinkTo /> directly into the MD link box won't work. Because of this and that I couldn't find templates/links in the left nav, I assumed the link broke 🤣I had to put it in side back ticks to work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for checking! 😱 Do you mind checking if the other PRs we merged lately have this problem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chancancode I checked the recently closed PR's. I can confirm that none of them have this issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@@ -86,33 +86,33 @@ method.

Note: A route with a dynamic segment will always have its `model` hook called when it is entered via the URL.
If the route is entered through a transition (e.g. when using the [link-to](../../templates/links/) Handlebars helper),
and a model context is provided (second argument to `link-to`), then the hook is not executed.
and a model context is provided (by passing in `@model` to `<LinkTo />`), then the hook is not executed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. model context -> model object
  2. I think we can just delete (by passing...)

@locks locks merged commit 1749315 into ember-learn:octane Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants