Update README.md #195
Closed
Update README.md #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for guidemaker-ember-template ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
IgnaceMaes
requested changes
Jun 30, 2024
There was a problem hiding this comment.
Can the current README template be used, but with the description of the old one?
Some sections no longer apply:
- The old compatibility info should be replaced with the new one
- The old running instructions are not applicable anymore. The new ones can be found here: https://github.com/ember-learn/guidemaker-ember-template/blob/main/CONTRIBUTING.md.
Closed
added 2 commits
July 1, 2024 13:13
|
Hi i made the changes and added the commits to this PR. Not sure if you wanted to put the releases section back but I did anyways, please let me know if further changes are needed. Thanks |
IgnaceMaes
requested changes
Jul 2, 2024
mansona
reviewed
Jul 2, 2024
Co-authored-by: Ignace Maes <[email protected]>
Co-authored-by: Ignace Maes <[email protected]>
Co-authored-by: Ignace Maes <[email protected]>
|
@raspberri05 it looks like you deleted your fork so we're not able to merge this any more? 🤔 was that a mistake? |
|
@mansona i made a new PR :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #193. Added back the readme contents lost during v2 conversion. Please let me know if this if fine or if some things need to be removed. I currently just switched it back to the readme that had all the information.