Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for EOL node < 18 #488

Merged
merged 2 commits into from
Oct 19, 2023
Merged

drop support for EOL node < 18 #488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0088de
drop support for EOL node < 18
mansona Oct 19, 2023
6c1aa57
use node-provided npm
mansona Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x
cache: npm
- run: npm i -g npm@8
- run: npm ci
- run: npx percy exec -- npm run test:docs

Expand All @@ -36,9 +35,8 @@ jobs:
- uses: mansona/npm-lockfile-version@v1
- uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x
cache: npm
- run: npm i -g npm@8
- run: npm ci
- run: npm run lint
- run: npx percy exec -- npm run test
Expand All @@ -51,9 +49,8 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x
cache: npm
- run: npm i -g npm@8
- run: npm install --no-shrinkwrap
- run: npm run test:ember

Expand Down Expand Up @@ -82,9 +79,8 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x
cache: npm
- run: npm i -g npm@8
- run: npm ci
- name: Run Tests
run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }}
Expand All @@ -107,9 +103,8 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x
cache: npm
- run: npm i -g npm@8
- run: npm ci
- name: Run Tests
id: tests
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
"webpack": "^5.52.1"
},
"engines": {
"node": "12.* || 14.* || >= 16"
"node": "18.* || >= 20"
},
"ember": {
"edition": "octane"
Expand All @@ -120,6 +120,6 @@
"configPath": "tests/dummy/config"
},
"volta": {
"node": "16.20.1"
"node": "18.18.2"
}
}