Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and cleanup CSS variables and related helpers #239

Merged
merged 7 commits into from
Oct 31, 2019
Merged

Update and cleanup CSS variables and related helpers #239

merged 7 commits into from
Oct 31, 2019

Conversation

pichfl
Copy link
Contributor

@pichfl pichfl commented Oct 30, 2019

There is no issue for this PR, but it was necessary to formalize the grayscale palette and other things.

@pichfl pichfl added design design is needed for this issue CSS ✨ Website Redesign RFC labels Oct 30, 2019
mansona
mansona approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing 🎉 thanks for your work on this 😍

@mansona mansona merged commit fee794c into website-redesign-rfc Oct 31, 2019
@delete-merged-branch delete-merged-branch bot deleted the variables branch October 31, 2019 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

@ghislaineguerin ghislaineguerin ghislaineguerin approved these changes

Assignees
No one assigned
Labels
CSS ✨ design design is needed for this issue Website Redesign RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pichfl @mansona @ghislaineguerin