Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outside spacing for containers on mobile #238

Merged
merged 4 commits into from
Oct 30, 2019
Merged

Conversation

pichfl
Copy link
Contributor

@pichfl pichfl commented Oct 30, 2019

This also introduces appropriate variables for the spacing and moves the container declaration into a single place.

Closes #231

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one thing that probably needs to be removed if we don't need it any more 👍

@media (min-width: 992px) {
@media (min-width: 984px) {
.es-header {
/* padding: 1.5rem var(--grid-margin); */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to be commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whops, no, this needs to be in

@pichfl pichfl merged commit eb267f0 into website-redesign-rfc Oct 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the containers branch October 30, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants