Css Helpers #221
Merged
Css Helpers #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mansona can you take a look at this please? I need the styles to close the team page PR. |
MelSumner
requested changes
Oct 24, 2019
| ## Spacing Helpers | ||
| In order to apply the spacing scale on pages, a set of predefined helper classes exist for both margins and paddings. | ||
|
|
||
| ### Margin Helpers |
There was a problem hiding this comment.
@mansona will we have a way to have margins be automatic so folks don't have to think about them? I'd like some sort of automatic margins based on viewport.
There was a problem hiding this comment.
In a lot of cases, the margins and padding will be automatic, but the point of including these helpers is so that people can make use of the margins and padding without the need to write css 👍 e.g. template only components
This particular change should have been moving the helper documentation from the Layout page to the CSS Helper page.
mansona
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add the css helpers needed to implement the website design.