using field-guide to document instead of markdown-templates #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
let me know if anyone has any questions 👍 |
Closed
|
A lot of components don’t seem to be functioning as expected. eg., on the footer page the styles seem to be broken & on the button page the disabled state doesn't seem to be set. Are these expected/known? |
|
@sivakumar-kailasam yes this is known already because they haven't been implemented in the redesign branch yet 👍 |
|
Oh, good to know.
Regards,
Siva
…On Tue, 25 Jun, 2019, 6:22 PM Chris Manson, ***@***.***> wrote:
@sivakumar-kailasam <https://github.com/sivakumar-kailasam> yes this is
known already because they haven't been implemented in the redesign branch
yet 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#186?email_source=notifications&email_token=AAETPVMRGAV2QN2IBIRM3DDP4IIKTA5CNFSM4H3CVTV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYQEGJQ#issuecomment-505430822>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAETPVOLRZWXSY6OVMEDFDDP4IIKTANCNFSM4H3CVTVQ>
.
|
MelSumner
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #180
This PR simplifies the documentation and hosting of the ember-styleguide (for the website redesign branch)
Before this PR we were using an addon called
ember-markdown-templatesthat was difficult to use and required you to be careful with how you did documentation.This PR starts using field-guide that allows us to just write Markdown with code examples that are self-executing, which allows for very straight forward documentation and demonstration.
Let me know if anyone has any questions, I would like to get this PR merged this week so that work can continue on the redesign effort 👍
Note for reviewers: you will see a lot of deletions in this PR, this is not actually removing any documentation. Now that code examples are self-executing you no longer need to duplicate the code in the example directly after code-block, and the deletions you are seeing are just these duplicates being removed because they are no longer necessary.