-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't merge before release: 3.13 blog post #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a couple small suggestions here, but I have one big suggestion: this is the last release before we flip the switch on Octane, and I think it'd be great if we said as loudly as possible THE NEXT RELEASE IS OCTANE, SO EVEN IF YOU DON'T NORMALLY TEST BETAS PLEAAAAASE TEST THE 3.14 BETA with a link to the Octane guides for how to test it out. 😄
@chriskrycho I think the plan is people should be able to test out Octane on this stable release by enabling the flag, since all the features are in this release already. |
@kennethlarsen Would you be open to @wycats and I adding an introductory section to this blog post setting the context for 3.13 and Octane? |
@tomdale I think that would be great! |
As the release before Octane, 3.13 contains significant new features that are part of the Octane programming model. This commit updates the post to expand on the relationship of 3.13 to Octane, describing it as the Octane preview, and provides guidance on how people should be thinking about adopting new features.
@kennethlarsen Awesome! @wycats and I put up our changes in a separate PR for you to review: #282. |
Co-Authored-By: Godfrey Chan <[email protected]>
Co-Authored-By: Godfrey Chan <[email protected]>
Co-Authored-By: Godfrey Chan <[email protected]>
Octane-related 3.13 blog post revisions
Co-Authored-By: David Mazza <[email protected]>
… into release/3-13-post
// .ember-cli.js | ||
const { setEdition } = require('@ember/edition-utils'); | ||
|
||
setEdition('octane'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Precisely what does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this switches the blueprints. If that's true, we should specifically say that.
|
||
Tracked properties introduce a simpler and more ergonomic system for tracking state change in Ember applications. Tracked properties allow Ember to reduce its API surface area while producing code that is both more intuitive and less error-prone. | ||
|
||
Have a look at the [guides] to learn more about tracked properties. For design details, check out [RFC 410](https://github.com/emberjs/rfcs/blob/master/text/0410-tracked-properties.md) and [RFC 478](https://github.com/emberjs/rfcs/blob/master/text/0478-tracked-properties-updates.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look at the [guides] to learn more about tracked properties. For design details, check out [RFC 410](https://github.com/emberjs/rfcs/blob/master/text/0410-tracked-properties.md) and [RFC 478](https://github.com/emberjs/rfcs/blob/master/text/0478-tracked-properties-updates.md). | |
Have a look at the [guides] to learn more about tracked properties. For design details, check out [RFC 410](https://github.com/emberjs/rfcs/blob/master/text/0410-tracked-properties.md) and [RFC 478](https://github.com/emberjs/rfcs/blob/master/text/0478-tracked-properties-updates.md). |
This should link to the API docs for tracked, ideally. If we have to, we can link to https://emberjs.com/editions/octane and say "have a look at the draft guides...."
|
||
## Ember 3.12 is an LTS Release | ||
|
||
If you are upgrading from the previous LTS version (3.8) to 3.12 then you are getting access to these features: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love this section, thank you!
// .ember-cli.js | ||
const { setEdition } = require('@ember/edition-utils'); | ||
|
||
setEdition('octane'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this switches the blueprints. If that's true, we should specifically say that.
Co-Authored-By: Jen Weber <[email protected]>
Co-Authored-By: Jen Weber <[email protected]>
Co-Authored-By: Jen Weber <[email protected]>
Co-Authored-By: Jen Weber <[email protected]>
|
||
If you are upgrading from the previous LTS version (3.8) to 3.12 then you are getting access to these features: | ||
|
||
* `router` service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The router service has been included since Ember 2.12
Suggest saying specifically how it was improved.
If you are upgrading from the previous LTS version (3.8) to 3.12 then you are getting access to these features: | ||
|
||
* `router` service | ||
* Support for native classes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ES classes have been supported since August 2017, when RFC 240 was accepted.
Suggest saying Native Class Constructor Update RFC implemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Native classes were not officially supported until v3.6 (RFC implementation was incomplete + redesign occurred, no blog post announcement, no API docs). 3.10 adds decorators, which made native classes viable/recommendable for most users, so maybe it should say "Support for native classes + decorators"
* Element Modifier Manager (and modifiers in general) | ||
* Nested angle bracket component invocation | ||
* Angle bracket invocation for built-in components | ||
* Support for native decorators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think any browser has native decorators. Reword?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chatted with Kenneth, and he says this is good to merge. I gave it a quick read through in the preview app and it all looks goo!
Ready for final review