Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application controller router properties deprecation #276

Merged
merged 3 commits into from
Apr 16, 2019

Conversation

locks
Copy link
Contributor

@locks locks commented Feb 6, 2019

No description provided.

Copy link
Contributor

@jenweber jenweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jenweber
Copy link
Contributor

Should we wait to merge this until 3.10 lands?

@locks
Copy link
Contributor Author

locks commented Apr 15, 2019

@jenweber up to you!

@rwjblue
Copy link
Contributor

rwjblue commented Apr 16, 2019

No, folks testing betas/canaries also see these urls, they should be valid nearly as soon as the deprecation itself is landed.

tldr; we should land these PR's ASAP 😸

@rwjblue rwjblue merged commit 99dd6b4 into master Apr 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the application-controller branch April 16, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants