Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use data diff in md #1385

Merged
merged 2 commits into from
Jul 23, 2024
Merged

refactor: use data diff in md #1385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12cc38f
refactor: use data diff in cli
IgnaceMaes Jul 7, 2024
29e798f
refactor: replace other diffs
IgnaceMaes Jul 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions content/ember-cli/v4/ember-cli-blacklist-whitelist-build-options.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,12 @@ displayId: ember-cli.blacklist-whitelist-build-options
Using the `blacklist` and `whitelist` build options has been deprecated. Please
use `exclude` and `include` respectively instead.

```diff
// ember-cli-build.js

```js {data-filename="ember-cli-build.js" data-diff="-4,+5"}
module.exports = function (defaults) {
const app = new EmberApp(defaults, {
addons: {
- blacklist: ['addon-name'],
+ exclude: ['addon-name'],
blacklist: ['addon-name'],
exclude: ['addon-name'],
},
};
};
Expand Down
18 changes: 9 additions & 9 deletions content/ember-cli/v5/ember-cli-output-paths-build-option.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,21 @@ Using the `outputPaths` build option is deprecated, as output paths will no long

To resolve the deprecation, please remove the `outputPaths` build option from your `ember-cli-build.js` file:

```diff
```js {data-diff="-3,-4,-5,-6,-7"}
module.exports = function (defaults) {
const app = new EmberApp(defaults, {
- outputPaths: {
- app: {
- js: `/assets/foo.js`,
- },
- },
outputPaths: {
app: {
js: `/assets/foo.js`,
},
},
};
};
```

And update your `app/index.html` file accordingly:

```diff
```html {data-diff="-20,+21"}
<!DOCTYPE html>
<html>
<head>
Expand All @@ -44,8 +44,8 @@ And update your `app/index.html` file accordingly:
{{content-for "body"}}

<script src="{{rootURL}}assets/vendor.js"></script>
- <script src="{{rootURL}}assets/foo.js"></script>
+ <script src="{{rootURL}}assets/my-app-name.js"></script>
<script src="{{rootURL}}assets/foo.js"></script>
<script src="{{rootURL}}assets/my-app-name.js"></script>

{{content-for "body-footer"}}
</body>
Expand Down
6 changes: 3 additions & 3 deletions content/ember-data/v4/ember-data-deprecate-string-arg-schemas.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Deprecates `schema.attributesDefinitionFor(type)` and `schema.relationshipsDefin

To resolve change:

```diff
- store.getSchemaDefinitionService().attributesDefinitionFor('user')
+ store.getSchemaDefinitionService().attributesDefinitionFor({ type: 'user' })
```js {data-diff="-1,+2"}
store.getSchemaDefinitionService().attributesDefinitionFor('user')
store.getSchemaDefinitionService().attributesDefinitionFor({ type: 'user' })
```