Fix Github actions not running #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ember-cli-addon-tests defaults to use ember-data 3.8 which is not compatible any more https://github.com/tomdale/ember-cli-addon-tests/blob/6f0beb154853d7e755a8007a30f01eb2b4f4a6dc/lib/utilities/pristine.js#L98 Also disable a test which throws: Error: Cannot find module 'abortcontroller-polyfill/dist/cjs-ponyfill'
xg-wang
force-pushed
the
fix-ci
branch
2 times, most recently
from
1bb1608 to
f63d2fb
Compare
snewcomer
reviewed
Aug 8, 2021
| @@ -32,7 +33,7 @@ describe('request details', function () { | |||
| .create('request', { | |||
| skipNpm: true, | |||
| emberVersion: 'latest', | |||
| emberDataVersion: 'latest', | |||
| emberDataVersion: '~3.19.0', | |||
There was a problem hiding this comment.
do we have problems with ember-fetch + ember-data?
There was a problem hiding this comment.
There was a problem hiding this comment.
I forgot if this is related to the error I saw in between commits. I'm just pinning ember-data to the version used in the project.
The ember-fetch issue is real, also seen at https://github.com/embroider-build/embroider/blob/28460bf58e75e653d917c2a97b6e616abf02d75b/tests/scenarios/fastboot-app-test.ts#L22 but I do not know why
Is the ember-fetch linked issue related?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI was skipped in #832