fix: crash with dynamic/variable route name in no-shadow-route-defini…

…tion rule
ember-cli · Mar 22, 2021 · 859d17c · 859d17c
1 parent 38c16f3
commit 859d17c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/rules/no-shadow-route-definition.js b/lib/rules/no-shadow-route-definition.js
@@ -57,6 +57,12 @@ module.exports = {
         if (!ember.isRoute(node)) {
           return;
         }
+
+        if (node.arguments.length > 0 && node.arguments[0].type !== 'Literal') {
+          // Ignore dynamic/variable route names.
+          return;
+        }
+
         const routeInfo = getRouteInfo(node);
         if (
           routeMap.has(routeInfo.route.fullPathWithGenericParams) &&

diff --git a/tests/lib/rules/no-shadow-route-definition.js b/tests/lib/rules/no-shadow-route-definition.js
@@ -98,6 +98,10 @@ ruleTester.run('no-shadow-route-definition', rule, {
       this.route('viewcollections', { path: 'viewcollections/:viewCollectionId' });
     });`,
 
+    // With dynamic/variable route or path name:
+    'this.route(someVariable);',
+    "this.route('views', { path: someVariable })",
+
     // Not Ember's route function:
     'test();',
     "test('blog');",