Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ember-cli 2.8 #98

Merged
merged 4 commits into from
Oct 3, 2016
Merged

Upgrade to ember-cli 2.8 #98

merged 4 commits into from
Oct 3, 2016

Conversation

kategengler
Copy link
Member

@kategengler kategengler commented Sep 29, 2016

Upgrade to ember-cli 2.8 and reduce # of travis runs to increase chances of all runs passing.

@kategengler kategengler changed the title Upgrade to ember-cli 2.8 [WIP] Upgrade to ember-cli 2.8 Oct 1, 2016
- Remove Node 0.10
- Only run node-side tests with different node versions
- Only run Node 5.x when it is run with coverage
@kategengler kategengler force-pushed the kg-upgrade-ember-cli branch from f1304ae to 81ad722 Compare October 1, 2016 23:24
@kategengler kategengler changed the title [WIP] Upgrade to ember-cli 2.8 Upgrade to ember-cli 2.8 Oct 1, 2016
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments/issues:

  • Should delete testem.json (it was replaced by testem.js).
  • We need to test in current stable node (6)


matrix:
fast_finish: true
include:
- node_js: "4.2"
env: NPM_SCRIPT=client-test
- node_js: "5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets swap this for 6? 6 is the current stable (as it is we aren't testing current stable at all), and will become an LTS soon (technically 2016-10-01 but I think there will need to be a release first).

@kategengler kategengler merged commit 34d1263 into master Oct 3, 2016
@kategengler kategengler deleted the kg-upgrade-ember-cli branch October 27, 2016 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants